30 秒でわかる
Theo Browne describes “guilt-merging” a pull request because someone invested effort and the alternative is an uncomfortable conversation. He asks developers to question the things they have become accustomed to protecting.
- 1Guilt-mergingTheo asks whether developers have merged a pull request because its author worked hard on it.
- 2Avoided conversationThe change may not be quite right, but the alternative is a conversation the reviewer does not want to have.
- 3Reconsider prioritiesHe suggests questioning the things developers care about and whether they still matter.
ポイント
- A pull request can be merged out of discomfort rather than confidence in the change.
- The effort invested in a change can make a difficult conversation harder.
- Theo encourages developers to question whether their existing priorities still matter.
チャプターごとに整えた全文を読む
Why do we guilt-merge?
Theo describes merging an unsuitable change out of guilt. He calls for questioning the assumptions behind that behavior.
Who here has guilt-merged a pull request? Someone put a lot of work into it, and even though it was not quite right, you merged it anyway because the alternative was a conversation you did not want to have.
Why do we do this to ourselves? My point is that we care too much, and the things we care about are not necessarily the things that matter anymore. I hope we can start challenging some of those assumptions.
同じチャンネルの記事
38:47EN
36:07EN
30:37EN
0:43EN
29:22EN
31:13EN